Add tests for string clip edge cases#45
Merged
NailxSharipov merged 2 commits intoiShape-Rust:mainfrom Jan 27, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
|
Everything is fine, except for the small rename wish. |
Contributor
Author
|
Hi, @NailxSharipov. Could you put it in more detail? |
Member
|
Yes. let rect = vec![
IntPoint::new(-2, -2),
IntPoint::new(2, -2),
IntPoint::new(3, 0),
IntPoint::new(-3, 0),
];this contour is not a rect, it is a trapezoid! just rename rect to contour or path so it will be: let contour = vec![
IntPoint::new(-2, -2),
IntPoint::new(2, -2),
IntPoint::new(3, 0),
IntPoint::new(-3, 0),
]; |
Contributor
Author
|
Ahh...for sure |
NailxSharipov
approved these changes
Jan 27, 2026
iOverlay/src/string/clip.rs
Outdated
|
|
||
| #[test] | ||
| fn test_shared_vertices_1() { | ||
| let rect = vec
There was a problem hiding this comment.
better to rename it to something neutral like path_0. It's not a rect right now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#33
Changes
Added corner-case tests for string clip
Testing
cargo testcargo fmtcargo clippyChecklist